Skip to content

vote: docs(OWNERS): move ekoops from reviewer to approver#299

Merged
poiana merged 1 commit intofalcosecurity:mainfrom
ekoops:patch-1
May 27, 2025
Merged

vote: docs(OWNERS): move ekoops from reviewer to approver#299
poiana merged 1 commit intofalcosecurity:mainfrom
ekoops:patch-1

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented May 20, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:

Hi folks! I would like to become an approver of the repo, as I like the project, and I want to extend my contribution beyond the suite command.

This PR moves myself from reviewer to approver. Let me now if it is fine for you! 😄

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Leonardo Di Giovanna <41296180+ekoops@users.noreply.github.com>
@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: yes labels May 20, 2025
@poiana poiana requested review from FedeDP and leogr May 20, 2025 15:06
@poiana poiana added the size/XS label May 20, 2025
@leogr
Copy link
Member

leogr commented May 20, 2025

ofc big +1 from 🚀

/hold until we get vote completed

@FedeDP
Copy link
Contributor

FedeDP commented May 21, 2025

Big +1 for me!!

@alacuku
Copy link
Member

alacuku commented May 27, 2025

+1 for me!

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, everyone agreed! 🥳

@ekoops welcome on board!

/hold cancel

@poiana
Copy link

poiana commented May 27, 2025

LGTM label has been added.

DetailsGit tree hash: f982ab52427a9a0bb9ae4371ba8f987c2e12c28a

@poiana
Copy link

poiana commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 217294e into falcosecurity:main May 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants